On 4/24/21 5:26 PM, Stefan Metzmacher wrote: > Hi, > > now that we have an explicit wake_up_new_task() in order to start the > result from create_io_thread(), we should set things up before calling > wake_up_new_task(). > > Changes in v3: > - rebased on for-5.13/io_uring. > - I dropped this: > fs/proc: hide PF_IO_WORKER in get_task_cmdline() > - I added: > set_task_comm() overflow checks Looks good to me, a few comments: 1) I agree with Pavel that the WARN on overflow is kinda silly, it doesn't matter that much. So I'd rather drop those for now. 2) Would really love it to see some decent commit messages, quite a few of them are empty. In general some reasoning is nice in the commit message, when you don't have the context available. Do you want to do a v4 with 5-6/6 dropped for now, and 3-4 having some reasoning? I can also just apply as-is and write some commit message myself, let me know. I'll add 1-2 for now. -- Jens Axboe
