On 14/04/2021 17:20, Jens Axboe wrote: > On 4/14/21 6:38 AM, Pavel Begunkov wrote: >> 1-2 are are small improvements >> >> The rest moves all poll update into IORING_OP_POLL_REMOVE, >> see 5/5 for justification. >> >> v2: fix io_poll_remove_one() on the remove request, not the one >> we cancel. > > I like moving update into remove, imho it makes a lot more sense. Will > you be sending a test case patch for it too? I was testing with your test case, 3 line change, can send it. We definitely need a helper though. There was something for liburing from Joakim, right? -- Pavel Begunkov