On Thu, Mar 04, 2021 at 04:25:41PM +0530, Kanchan Joshi wrote:
> On Thu, Mar 4, 2021 at 12:22 AM Chaitanya Kulkarni
> <Chaitanya.Kulkarni@xxxxxxx> wrote:
> >
> > On 3/2/21 23:22, Kanchan Joshi wrote:
> > > + switch (bcmd->ioctl_cmd) {
> > > + case NVME_IOCTL_IO_CMD:
> > > + ret = nvme_user_cmd(ns->ctrl, ns, argp, ioucmd);
> > > + break;
> > > + default:
> > > + ret = -ENOTTY;
> > > + }
> > Switch for one case ? why not use if else ?
>
> Indeed, I should have used that. I had started off with more than one,
> and retracted later.
I have to say I really do like the switch for ioctl handlers, as they
are designed as a multiplexer, and nothing screams multiplexer more
than a switch statement.
