Re: [PATCH 8/8] io_uring: warn when ring exit takes too long

[Jens Axboe <axboe@xxxxxxxxx>]

On 3/4/21 6:59 AM, Pavel Begunkov wrote:
> We use system_unbound_wq to run io_ring_exit_work(), so it's hard to
> monitor whether removal hang or not. Add WARN_ONCE to catch hangs.

Minor nit, but I'd just use jiffies for this. Ala:

unsigned long timeout = jiffies + 60 * HZ;

if (time_after(jiffies, timeout))
    complain();

That's a well known idiom, and we don't need better precision than that.

-- 
Jens Axboe