On 3/4/21 1:50 PM, Linus Torvalds wrote: > On Thu, Mar 4, 2021 at 11:54 AM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> I agree, here are the two current patches. Just need to add the signal >> blocking, which I'd love to do in create_io_thread(), but seems to >> require either an allocation or provide a helper to do it in the thread >> itself (with an on-stack mask). > > Hmm. Why do you set SIGCHLD in create_io_thread()? Do you actually use > it? Shouldn't IO thread exit be a silent thing? Good catch, I will drop that. > And why do you have those task_thread_bound() and > task_thread_unbound() functions? As far as I can tell, you have those > two functions just to set the process worker flags. Already dropped that, it's not in the current set. > Why don't you just do that now inside create_io_worker(), and the > whole task_thread_[un]bound() thing goes away, and you just always > start the IO thread in task_thread() itself? That's exactly what I did: https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.12&id=dda3b920327093a2bb8c2e5db26db9203d7f60e6 -- Jens Axboe
