On 2/12/21 12:51 PM, Linus Torvalds wrote: > On Fri, Feb 12, 2021 at 6:08 AM Jens Axboe <axboe@xxxxxxxxx> wrote: >> >> Revert of a patch from this release that caused a regression. > > I really wish that revert had more of an explanation of _why_ it > needed to retain the ->fs pointer. > > I can guess at it, but considering that we got it wrong once, it might > be better to not have to guess, and have it documented. We end up doing path resolution for certain cases, so having the right fs_struct ends up being paramount. Do you want me to update the commit with a fuller description? -- Jens Axboe