Re: bug with fastpoll accept and sqpoll + IOSQE_FIXED_FILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Please don't forget about checking error codes. At least fixed
> > files don't work for you because of
> >
> > int fds[10];
> > memset(fds, -1, 10); // 10 bytes, not 10 ints
> >
> > So io_uring_register_files() silently fails.

well i'm glad this one was my own careless error. fresh eyes are
everything. you're right, bad habit of ignoring return values lol.

> Also you forget to submit, all works with these 2 changes.
>
> When you don't do io_uring_submit(), apparently it gets live-locked
> in liburing's _io_uring_get_cqe(), that's a bug.

in the comments above io_uring_wait_cqe_timeout it says it submits for
you, that's why i didn't submit here. but i guess great if that
exposed the _io_uring_get_cqe bug.

thanks so much for taking a look at this Pavel



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux