On 15/01/2021 18:38, Jens Axboe wrote: > On 1/15/21 11:31 AM, Marcelo Diop-Gonzalez wrote: >> On Fri, Jan 15, 2021 at 10:02:12AM -0700, Jens Axboe wrote: >>> On 1/15/21 9:54 AM, Marcelo Diop-Gonzalez wrote: >>>> This patch tries to fix a problem with IORING_OP_TIMEOUT events >>>> not being flushed if they should already have expired. The test below >>>> hangs before this change (unless you run with $ ./a.out ~/somefile 1): >>> >>> Can you turn this into a test case for liburing? I'll apply the >>> associated patch, thanks (and to Pavel for review as well). >> >> Yup, can do. I'll try to clean it up some first (especially so it >> doesn't just hang when it fails :/) > > That'd of course be nice, but not a hard requirement. A lot of the > regressions tests will crash a broken kernel, so... Ha, they definitely will. Marcelo, replacing reads with nop requests should trigger it as well, it's probably easier and even more reliable as we always complete them inline (if not linked or IOSQE_ASYNC). -- Pavel Begunkov