On 12/21/20 10:40, Pavel Begunkov wrote: > @@ -8866,7 +8865,12 @@ static int io_uring_add_task_file(struct io_ring_ctx *ctx, struct file *file) > > if (!old) { > get_file(file); > - xa_store(&tctx->xa, (unsigned long)file, file, GFP_KERNEL); > + ret = xa_err(xa_store(&tctx->xa, (unsigned long)file, > + file, GFP_KERNEL)); > + if (ret) { > + fput(file); > + return ret; > + } > } > tctx->last = file; > } Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>