On 10/28/20 7:00 PM, Simon Zeni wrote: > On Wed Oct 28, 2020 at 12:31 PM EDT, Jens Axboe wrote: >> All of this good stuff should be in the commit message before >> the '---' or it won't make it into the git log. Which would be a >> shame! >> >> I get a bunch of these with this applied: >> >> In file included from /usr/include/x86_64-linux-gnu/sys/types.h:25, >> from setup.c:4: >> /usr/include/features.h:187:3: warning: #warning "_BSD_SOURCE and >> _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] >> 187 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use >> _DEFAULT_SOURCE" >> | ^~~~~~~ > > I didn't want to fill the commit message with my patch explanation but I > can make a v2 to fix that definition warning and add the text into the > commit if you want. That's what it's there for! The commit message is basically useless without that added, the only bit you left is a throw-away. -- Jens Axboe
