On 10/15, Jens Axboe wrote: > > Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx> Yes, but ... > +static void task_work_notify_signal(struct task_struct *task) > +{ > +#if defined(CONFIG_GENERIC_ENTRY) && defined(TIF_NOTIFY_SIGNAL) as long as defined(CONFIG_GENERIC_ENTRY) goes away ;) Thomas, I strongly, strongly disagree with you. But even if you are right and only CONFIG_GENERIC_ENTRY arches should use TIF_NOTIFY_SIGNAL, why should this series check CONFIG_GENERIC_ENTRY ? You can simply nack the patch which adds TIF_NOTIFY_SIGNAL to arch/xxx/include/asm/thread_info.h. Oleg.