On 10/15/20 8:34 AM, Thomas Gleixner wrote: > On Thu, Oct 15 2020 at 08:31, Jens Axboe wrote: >> On 10/15/20 8:11 AM, Thomas Gleixner wrote: >> We could, should probably make it: >> >> static void handle_signal_work(ti_work, regs) >> { >> if (ti_work & _TIF_NOTIFY_SIGNAL) >> tracehook_notify_signal(); >> >> if (ti_work & _TIF_SIGPENDING) >> arch_do_signal(regs); >> } >> >> and then we can skip modifying arch_do_signal() all together, as it'll >> only be called if _TIF_SIGPENDING is set. > > Then you loose the syscall restart thing which was the whole point of > this exercise :) Hah oh yeah, good point... But then we need to touch every arch do_signal() anyway, so probably not much point in making the change then. -- Jens Axboe