On 10/14/20 2:00 PM, Pavel Begunkov wrote: > On 14/10/2020 20:53, Jens Axboe wrote: >> On 10/14/20 1:44 PM, Pavel Begunkov wrote: >>> A naive test with io_uring-bench with [nops, submit/complete batch=32] >>> shows 5500 vs 8500 KIOPS. Not really representative but might hurt if >>> left without [1/2]. >> >> Part of this is undoubtedly that we only use the task_work for things >> that need signaling, for the deferred put case we should be able to >> get by with using notfy == 0 for task_work. >> >> That said, it's nice to avoid when possible. At this point, I'd like >> to fold these into the last patch of the original series. What do you >> think? > > Yep, was thinking the same. It's better to be in 5.10, and that would > be easier to do by squashing. OK, done. -- Jens Axboe