On 9/25/20 2:32 AM, Stefano Garzarella wrote:
> On Thu, Sep 24, 2020 at 02:59:33PM -0600, Jens Axboe wrote:
>> io_uring: ensure open/openat2 name is cleaned on cancelation
>>
>> If we cancel these requests, we'll leak the memory associated with the
>> filename. Add them to the table of ops that need cleaning, if
>> REQ_F_NEED_CLEANUP is set.
>>
>
> IIUC we inadvertently removed 'putname(req->open.filename)' from the cleanup
> function in commit e62753e4e292 ("io_uring: call statx directly").
>
> Should we add the Fixes tag?
>
> Fixes: e62753e4e292 ("io_uring: call statx directly")
You are right, I got a bit tricked by it since that commit removed
the putname(), and then later on we got rid of the (now) empty
openat/openat2 entries.
I'll add the fixes, which means it's 5.8 only.
> Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
Added, thanks for reviewing!
--
Jens Axboe
