On 9/8/20 2:58 PM, Pavel Begunkov wrote: > On 08/09/2020 20:48, Jens Axboe wrote: >> Fd instantiating commands like IORING_OP_ACCEPT now work with SQPOLL, but >> we have an error in grabbing that if IOSQE_ASYNC is set. Ensure we assign >> the ring fd/file appropriately so we can defer grab them. > > IIRC, for fcheck() in io_grab_files() to work it should be under fdget(), > that isn't the case with SQPOLL threads. Am I mistaken? > > And it looks strange that the following snippet will effectively disable > such requests. > > fd = dup(ring_fd) > close(ring_fd) > ring_fd = fd Not disagreeing with that, I think my initial posting made it clear it was a hack. Just piled it in there for easier testing in terms of functionality. But the next question is how to do this right... -- Jens Axboe
