On Mon, Sep 07, 2020 at 01:34:38PM -0600, Jens Axboe wrote: > On 9/7/20 7:22 AM, Lukas Czerner wrote: > > Signed-off-by: Lukas Czerner <lczerner@xxxxxxxxxx> > > This patch really needs some justification. I generally try to make sure > that older kernel skip tests appropriately, sometimes I miss some and I > fix them up when I find them. > > So just curious what the use case is here for skipping tests? Not > adverse to doing it, just want to make sure it's for the right reasons. I think this is very useful, at least for me, in situation where some tests are causeing problems (like hangs, panics) that are not fixed yet, but I would still like to run entire tests suite to make sure my changes in didn't break anything else. I find it especially usefull in rapidly evolving project like this. I have a V2 patches with that justification in place and some minor changes. I'll be sending that (hopefuly it won't take hours this time). Thanks! -Lukas > > -- > Jens Axboe >
