On 9/2/20 10:35 PM, Xiaoguang Wang wrote: > hi， > >> On 9/2/20 5:32 AM, Xiaoguang Wang wrote: >>> While registering new files by IORING_REGISTER_FILES, there're not >>> valid fixed_file_ref_node at the moment, so it's unnecessary to hold >>> fixed_file_data's lock when registering files. >> >> Even if that were the case (I haven't looked too closely at it yet), >> it would a) need a big comment explaining why, and b) some justification >> on why this would be a change we'd want to make. >> >> On b, are you seeing any tangible differences with this? > No, just found this by reading source codes. OK, then I suggest we leave it as it is. The data race analyzers wouldn't be very happy with it either. -- Jens Axboe
