Re: [PATCH] io_uring: fail poll arm on queue proc failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/12/20 2:39 AM, Stefano Garzarella wrote:
> On Tue, Aug 11, 2020 at 09:52:55AM -0600, Jens Axboe wrote:
>> Check the ipt.error value, it must have been either cleared to zero or
>> set to another error than the default -EINVAL if we don't go through the
>> waitqueue proc addition. Just give up on poll at that point and return
>> failure, this will fallback to async work.
>>
>> io_poll_add() doesn't suffer from this failure case, as it returns the
>> error value directly.
>>
>> Cc: stable@xxxxxxxxxxxxxxx # v5.7+
>> Reported-by: syzbot+a730016dc0bdce4f6ff5@xxxxxxxxxxxxxxxxxxxxxxxxx
>> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> 
> LGTM:
> Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>

Thanks for the review, added.

-- 
Jens Axboe




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux