On 2020/8/5 上午9:43, Jens Axboe wrote: > On 8/4/20 7:08 PM, Jiufei Xue wrote: >> >> >> On 2020/8/4 下午6:25, Stefan Metzmacher wrote: >>> Am 04.08.20 um 11:21 schrieb Jiufei Xue: >>>> Kernel can handle timeout when feature IORING_FEAT_GETEVENTS_TIMEOUT >>>> supported. Applications should use io_uring_set_cqwait_timeout() >>>> explicitly to asked for the new feature. >>>> >>>> In addition in this commit we add two new members to io_uring and a pad >>>> for future flexibility. So for the next release, applications have to >>>> re-compile against the lib. >>> >>> I don't think this is an option, existing applications need to work. >>> >>> Or they must fail at startup when the runtime dependencies are resolved. >>> Which means the soname of the library has to change. >>> >> >> Yes, I think the version should bump to 2.0.X with next release. >> >> Jens, >> should I bump the version with this patch set? Or you will bump it >> before next release. > > It should get bumped with the change, otherwise things will fail before > the next release in case people run the git version. > > And while you're at it, add some more pad. Don't want to go through > the same process again the next time we need a bit of space. Just add > 4 unsigneds as pad at least, that's enough for a pointer and 2 > 32-bit entries. > ok. I will send version 3 later with these modification. Thank, Jiufei
