On 6/20/20 3:59 AM, Pavel Begunkov wrote:
> On 20/06/2020 02:57, Bijan Mottahedeh wrote:
>> If current->mm is not set in SQPOLL mode, then use ctx->sqo_mm;
>> otherwise fail thre request.
>
> io_sq_thread_acquire_mm() called from io_async_buf_retry() should've
> guaranteed presence of current->mm. Though, the problem could be in
> "io_op_defs[req->opcode].needs_mm" check there, which is done only
> for the first request in a link.
Right, Bijan are you sure this isn't fixed by one of the fixes that
went upstream yesterday:
commit 9d8426a09195e2dcf2aa249de2aaadd792d491c7
Author: Jens Axboe <axboe@xxxxxxxxx>
Date: Tue Jun 16 18:42:49 2020 -0600
io_uring: acquire 'mm' for task_work for SQPOLL
--
Jens Axboe
