On 5/19/20 3:52 PM, Bijan Mottahedeh wrote: > kiocb.private is used in iomap_dio_rw() so store buf_index separately. Hmm, that's no good, the owner of the iocb really should own ->private as well. The downside of this patch is that io_rw now spills into the next cacheline, which propagates to io_kiocb as well. iocb has 4 bytes of padding, but probably cleaner if we can stuff it into io_kiocb instead. How about adding a u16 after opcode? There's a 2 byte hole there, so it would not impact the size of io_kiocb. -- Jens Axboe