On 10/04/2020 20:51, Pavel Begunkov wrote: >> I added an assert in do_madvise() for a NULL mm value and hit it running the test. >> >>> What tree do you use? Extra patches on top? >> >> I'm using next-20200409 with no patches. > > I see, it came from 676a179 ("mm: pass task and mm to do_madvise"), which isn't > in Jen's tree oops, sorry for mistyping your name. > > I don't think your patch will do, because it changes mm refcounting with extra > mmdrop() in io_req_work_drop_env(). That's assuming it worked well before. > > Better fix then is to make it ```do_madvise(NULL, current->mm, ...)``` > as it actually was at some point in the mentioned patch (v5). Jens, how this should be handled? Through what tree it has to go? -- Pavel Begunkov