On 3/12/20 5:16 AM, Xiaoguang Wang wrote: > The fio_option_is_set() call in fio_ioring_prep() is time-consuming, > which will reduce sqe's submit rate drastically. To fix this issue, > add two new variables to record whether ioprio_class or ioprio_set > is set. I use a simple fio job to evaluate the performance: > fio -name=fiotest -filename=/dev/nvme0n1 -iodepth=4 -thread -rw=read > -ioengine=io_uring -hipri=0 -sqthread_poll=0 -direct=1 -bs=4k -size=10G > -numjobs=1 -time_based -runtime=120 > > Before this patch: > READ: bw=969MiB/s (1016MB/s), 969MiB/s-969MiB/s (1016MB/s-1016MB/s), > io=114GiB (122GB), run=120001-120001msec > > With this patch: > READ: bw=1259MiB/s (1320MB/s), 1259MiB/s-1259MiB/s (1320MB/s-1320MB/s), > io=148GiB (158GB), run=120001-120001msec Thanks, in hindsight that was pretty dumb! -- Jens Axboe