On 2/29/20 5:21 AM, Pavel Begunkov wrote: > On 2/28/2020 11:30 PM, Jens Axboe wrote: > >> +static int io_rw_common_cflags(struct io_kiocb *req) > > Sounds more like sort of const/idempotent function, but not one changing > internal state (i.e. deallocation kbuf). Could it be named closer to > deallocate, remove, disarm, etc? io_put_kbuf() or something like that is probably better. -- Jens Axboe