On 2/26/20 1:33 AM, Pavel Begunkov wrote: > On 26/02/2020 01:18, Jens Axboe wrote: >> So this found something funky, we really should only be picking up >> the next request if we're dropping the final reference to the >> request. And io_put_req_find_next() also says that in the comment, >> but it always looks it up. That doesn't seem safe at all, I think >> this is what it should be: > > It was weird indeed, it looks good. And now it's safe to do the same in > io_wq_submit_work(). It is. > Interestingly, this means that passing @nxt into the handlers is useless, as > they won't ever return !=NULL, isn't it? I'll prepare the cleanup. Indeed! That means we can get rid of that. We should do that for 5.7, though. -- Jens Axboe
