On 1/27/20 7:07 AM, Pavel Begunkov wrote: > On 1/27/2020 4:39 PM, Jens Axboe wrote: >> On 1/27/20 6:29 AM, Pavel Begunkov wrote: >>> On 1/26/2020 8:00 PM, Jens Axboe wrote: >>>> On 1/26/20 8:11 AM, Pavel Begunkov wrote: >>>>> On 1/26/2020 4:51 AM, Daurnimator wrote: >>>>>> On Fri, 24 Jan 2020 at 10:16, Jens Axboe <axboe@xxxxxxxxx> wrote: >>> Ok. I can't promise it'll play handy for sharing. Though, you'll be out >>> of space in struct io_uring_params soon anyway. >> >> I'm going to keep what we have for now, as I'm really not imagining a >> lot more sharing - what else would we share? So let's not over-design >> anything. >> > Fair enough. I prefer a ptr to an extendable struct, that will take the > last u64, when needed. > > However, it's still better to share through file descriptors. It's just > not secure enough the way it's now. Is the file descriptor value really a good choice? We just had some confusion on ring sharing across forks. Not sure using an fd value is a sane "key" to use across processes. -- Jens Axboe
