On 1/22/20 11:22 AM, Dmitry Sychov wrote: >> You mean the one in liburing? > > I'am referring to > https://github.com/frevib/io_uring-echo-server/blob/master/src/include/liburing/io_uring.h > with sockets OPs as the latest interface reference, thinking it will > help the io_uring newcomers if > IORING_OP_* lines will have corresponding comments of the minimum > kernel requirement for now and the future. The above obviously isn't mine, but it's probably forked/pulled from my liburing. I think the best thing to do here is update the io_uring_enter(2) man page, since it has opcode descriptions. In those descriptions, each of them should include "Supported since version 5.x" to make this perfectly clear. Longer term, I expect the probe to be the most useful for applications. I don't want to change io_uring.h itself, as I've keep that sane so it can simply be copied from the kernel repository to liburing. I intend to keep it that way. -- Jens Axboe
