On 18/01/2020 23:46, Jens Axboe wrote: > On 1/18/20 10:22 AM, Pavel Begunkov wrote: >> For each IOSQE_* flag there is a corresponding REQ_F_* flag. And there >> is a repetitive pattern of their translation: >> e.g. if (sqe->flags & SQE_FLAG*) req->flags |= REQ_F_FLAG* >> >> Use same numeric values/bits for them and copy instead of manual >> handling. I wonder, why this isn't a common practice around the kernel. E.g. I'm looking at iocb_flags() and kiocb_set_rw_flags(), and their one by one flags copying is just wasteful. > > Thanks, applied. > -- Pavel Begunkov
Attachment:
signature.asc
Description: OpenPGP digital signature
