On 1/18/20 10:10 AM, Pavel Begunkov wrote:
> On 18/01/2020 19:34, Jens Axboe wrote:
>>> +enum {
>>> + /* correspond one-to-one to IOSQE_IO_* flags*/
>>> + REQ_F_FIXED_FILE = BIT(REQ_F_FIXED_FILE_BIT), /* ctx owns file */
>>
>> I'd put the comment on top of the line instead, these lines are way too
>> long.
>
> I find it less readable, but let's see
Well, the monster lines are unreadable on an 80-char display... I'm generally
not a stickler with 80 chars, if a few over needs we don't need to break,
I'm all for it. But the long comments are unreadable for me.
--
Jens Axboe
