On 11/21/19 7:28 AM, Pavel Begunkov wrote: >>> >>> Was that a reviewed-by from you? It'd be nice to get these more >>> formally so I can add the attributes. I'll drop the other patch. >> >> I want to do more tests. There is no test machine at this time, at least >> until tomorrow morning. >> > BTW, aside from the locking problem, that it fixes another one. If > allocation for a shadow req is failed, io_submit_sqes() just continues > without it ignoring draining. Indeed. BTW, your commit message is way too weak for this patch. It doesn't explain why we're making this change at all. I'm going to fix it up. -- Jens Axboe
