On Tue, Jun 28, 2016 at 03:55:15PM +0530, Goel, Akash wrote: > >>+ pinned = (obj->pages_pin_count > 1); > > > >Too many () > > Sorry is the above condition not correct ? > If pin count is more than 1 then it implies that pages have been > pinned elsewhere also, so pages were already pinned before they were > pinned > one more time, inside this function. The definition of pinned is correct, just the () are redundant: pinned = obj->pages_pin_count > 1; -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx