On 07/06/16 21:00, Chris Wilson wrote:
On Tue, Jun 07, 2016 at 02:23:34PM +0100, Tvrtko Ursulin wrote:
On 07/06/16 11:54, Dave Gordon wrote:
On 07/06/16 09:43, Patchwork wrote:
== Series Details ==
Series: series starting with [1/3] drm/i915/guc: fix GuC
loading/submission check
URL : https://patchwork.freedesktop.org/series/8380/
State : failure
== Summary ==
Series 8380v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/8380/revisions/1/mbox
Test core_auth:
Subgroup basic-auth:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test drv_module_reload_basic:
pass -> DMESG-WARN (ro-byt-n2820)
Bug 93381 - [BAT BYT] dmesg WARNING in snd-hda
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-cmd:
pass -> FAIL (ro-byt-n2820)
Bug 95372 - [BAT BYT] Sporadic failure from
igt/gem_exec_flush@basic-batch-kernel-default-cmd
Subgroup basic-uc-ro-default:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup basic-wb-ro-before-default:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test gem_exec_store:
Subgroup basic-bsd:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Test gem_mmap_gtt:
Subgroup basic-short:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup basic-write-gtt:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test gem_pwrite:
Subgroup basic:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test kms_addfb_basic:
Subgroup addfb25-bad-modifier:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup addfb25-yf-tiled:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup bad-pitch-0:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup bad-pitch-1024:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Subgroup basic-x-tiled:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Subgroup basic-y-tiled:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup clobberred-modifier:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Subgroup tile-pitch-mismatch:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
All the warnings on 'ro-skl-i7-6700hq' appear to be
https://bugs.freedesktop.org/show_bug.cgi?id=95632
"[BAT SKL] *ERROR* Potential atomic update failure on pipe A"
So all issues accounted for, patchset ready for merge :)
.Dave.
fi-bdw-i7-5557u total:102 pass:93 dwarn:0 dfail:0 fail:0 skip:8
fi-hsw-i7-4770k total:209 pass:190 dwarn:0 dfail:0 fail:0
skip:19
fi-skl-i7-6700k total:209 pass:184 dwarn:0 dfail:0 fail:0
skip:25
fi-snb-i7-2600 total:209 pass:170 dwarn:0 dfail:0 fail:0
skip:39
ro-bdw-i5-5250u total:102 pass:93 dwarn:0 dfail:0 fail:0 skip:8
ro-bdw-i7-5600u total:102 pass:75 dwarn:0 dfail:0 fail:0
skip:26
ro-bsw-n3050 total:209 pass:168 dwarn:0 dfail:0 fail:2
skip:39
ro-byt-n2820 total:209 pass:168 dwarn:1 dfail:0 fail:3
skip:37
ro-hsw-i3-4010u total:209 pass:186 dwarn:0 dfail:0 fail:0
skip:23
ro-hsw-i7-4770r total:102 pass:82 dwarn:0 dfail:0 fail:0
skip:19
ro-ilk1-i5-650 total:204 pass:146 dwarn:0 dfail:0 fail:1
skip:57
ro-skl-i7-6700hq total:204 pass:172 dwarn:11 dfail:0 fail:0
skip:21
ro-snb-i7-2620M total:102 pass:72 dwarn:0 dfail:0 fail:0
skip:29
fi-skl-i5-6260u failed to connect after reboot
ro-bdw-i7-5557U failed to connect after reboot
ro-ivb2-i7-3770 failed to connect after reboot
ro-ivb-i7-3770 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_1125/
55d1291 drm-intel-nightly: 2016y-06m-06d-16h-28m-05s UTC integration
manifest
57871c9 drm/i915/guc: enable GuC loading & submission by default
3fdd902 drm/i915/guc: disable GuC submission earlier during GuC (re)load
5492d57 drm/i915/guc: fix GuC loading/submission check
Merged, thanks for the patches and review.
What review? This patch has not addressed my concerns at all.
It is changes the default submission and makes Skylake slower for what
benefit? The changelog still doesn't explain why we would want to take
the risk and current regressions.
-Chris
*"It's Intel POR"*
That means people higher up the foodchain have decided that the GuC is
the future and the minions have just got to get on with it.
Of course, if it introduces real regressions we'll turn it off again
until they're resolved, but we're more likely to discover any remaining
issues with it on by default -- otherwise it's just not getting much
exposure beyond the in-house validation.
Let's just hope they're all exposed and resolved before September!
.Dave.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
