On pe, 2016-06-03 at 17:36 +0100, Chris Wilson wrote: > We know, by design, that whilst the GPU is active (and thus we are > throttling) the retire_worker is queued. Therefore attempting to requeue > it with queue_delayed_work() is a no-op and we can safely remove it. > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_gem.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > index e27c9331b84b..da44715c894f 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -4181,9 +4181,6 @@ i915_gem_ring_throttle(struct drm_device *dev, struct drm_file *file) > return 0; > > ret = __i915_wait_request(target, true, NULL, NULL); > - if (ret == 0) > - queue_delayed_work(dev_priv->wq, &dev_priv->gt.retire_work, 0); > - > i915_gem_request_unreference(target); > > return ret; -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
