On Fri, Jun 03, 2016 at 06:04:36PM +0300, Ville Syrjälä wrote: > On Fri, Jun 03, 2016 at 03:36:52PM +0100, Chris Wilson wrote: > > In the very near future, we will perform the backlight setup > > consistently during connector registration - moving the setup further > > away from the intel_panel_init call and to where we no longer know the > > associated pipe. To pass that information along we need to store it > > during init. > > This looks like the wrong approach. The setup hook should be called > at connector init time. In fact the code looks correcto to me already, > as in we have two phases already: setup and register. But currently setup is being called at connector register time (post drm_connector_register), so I took the coward's approach and preserved that ordering. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
