Re: [PATCH 0/8] drm/i915: Give crtcs and planes actual names (v5)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 27, 2016 at 09:21:45PM +0100, Chris Wilson wrote:
> On Fri, May 27, 2016 at 08:59:18PM +0300, ville.syrjala@xxxxxxxxxxxxxxx wrote:
> > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> > 
> > This is the remainder (the i915 specific parts) of my earlier
> > {crtc,plane}->name series [1]. I think at least one i915 specific patch
> > was already merged, and I think I added one or two new ones at some
> > point.
> 
> Making the message more informative is always appreciated, and I
> couldn't spot anything blatantly wrong,
> 
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>  
> > I'm not so sure about the last patch. It was somewhat useful in narrowing
> > down some underrun locations and whatnot for me, but normally it might
> > be just noise. So I'm happy to keep it in my private stash for a rainy day
> > if people are fed up with dmesg spam.
> 
> If you have a compelling usecase, it's not the worst thing we've ever
> done. If there's no rush, we should try to leverage ftrace, or something
> similar, rather than roll our own partial solution.

I've pushed everything but the last patch to dinq. Thanks for the
review.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux