Re: [PATCH 2/6] drm/i915: Treat kernel context as initialised

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 25, 2016 at 03:38:44PM +0300, Joonas Lahtinen wrote:
> On ke, 2016-05-25 at 12:48 +0100, Chris Wilson wrote:
> > +	for_each_engine(engine, dev_priv) {
> > +		struct intel_context *ce =
> > +			&dev_priv->kernel_context->engine[engine->id];
> > +
> > +		ce->initialised =
> > +			!i915.enable_execlists || engine->init_context == NULL;
> > +	}
> 
> <NL> here?

Not sure.

For, keep it tight with the comment and similar to the code it replaced.

Against, whitespace is good.

It's moot as this line disappears in a couple of patches time. I
preferred trying to show the semantic similarity in the patch.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux