Re: [PATCH 1/4 v3] drm/i915: Early exit from rps worker if GPU is idle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 17, 2016 at 04:40:38PM +0200, Michał Winiarski wrote:
> This allows us to avoid the situation where worker is increasing the GPU
> frequency after we've switched to idle.
> 
> v2: Do not access ->mm.busy under ->irq_lock
> v3: Really do not access ->mm.busy under ->irq_lock

This is backwards. The rps worker should not be running when the device
is idle. The code tries to do that currently but fails, so I think this
as papering over the bug.

Fixing this means we can remove the DISABLE_RPM_WAKEREF_ASSERTS. The
patch I've previously sent does
https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=tasklet&id=1c0ace26e80188e53a18977e5ef90ab8a801027c
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux