Re: [PATCH i-g-t v2] autotools/: Allow building tests/gem_concurrent_{all, blit}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 17.05.2016 13:02, Daniel Vetter wrote:
On Mon, May 16, 2016 at 06:09:27PM +0300, Marius Vlad wrote:
Trivial. Pushed.

On Mon, May 16, 2016 at 01:36:48PM +0300, Marius Vlad wrote:
Introduced by a633ad03c6 (tests: Separate tests with lots of subtests).

v2: Fix commit typo (Jani Nikula).

Signed-off-by: Marius Vlad <marius.c.vlad@xxxxxxxxx>

Also review from my side on the offending original commit was ignored -
imo gem_concurrent_all should just be put into EXTRA, and
gem_concurrent_blit should be kept in the normal igt set of testcases.

Dropping gem_concurrent_blit from the list of tests means we have a
massive gap in coverage. If that one still has too many subtests we need
to filter them harder, but that's a different problem.

gem_concurrent_all can still be tested, using test-list-full.txt instead.
Now, piglit igt profile has hardcoded "test-list.txt" (plus "single-tests.txt" and "multi-tests.txt" - which I guess are history). We can specify which test list to use with a change in piglit (by redefining IGT_TEST_ROOT or another var). Alternatively test-list.txt can be replaced with test-list-full.txt (or symlink).

Regards,
Gabriel.


Also pls run $ make distcheck before pushing stuf ...
-Daniel

---
  tests/Makefile.am | 1 +
  1 file changed, 1 insertion(+)

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 32b9115..c2c2025 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -30,6 +30,7 @@ pkglibexec_PROGRAMS = \
  	gem_stress \
  	$(TESTS_progs) \
  	$(TESTS_progs_M) \
+	$(TESTS_progs_XM) \
  	$(NULL)

  dist_pkglibexec_SCRIPTS = \
--
2.8.0.rc3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux