On Tue, May 17, 2016 at 01:05:13PM +0300, Jani Nikula wrote:
> On Tue, 17 May 2016, Daniel Vetter <daniel@xxxxxxxx> wrote:
> > On Wed, May 11, 2016 at 12:42:06PM +0300, Jani Nikula wrote:
> >> -type_name_fn(encoder_type)
> >> +const char *kmstest_encoder_type_str(int type)
> >> +{
> >> + return find_type_name(encoder_type_names, type);
> >> +}
> >
> > We should have gtkdoc for these now too, or maybe we had but somewhere
> > else?
>
> We still do, in igt_kms.h, where they didn't help me in the least
> finding the definitions...
Can you please move the to the .c file then in a quick follow-up? We tend
to only have gtkdoc in headers for #defines and static inlines. For
consistency and OCD, and because that way the gtkdoc is always next to the
code it documents (like in the kernel). Ack from me and just push the
patch right way.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
