On Wed, May 04, 2016 at 02:30:28PM +0200, Maarten Lankhorst wrote: > Op 29-04-16 om 16:31 schreef ville.syrjala@xxxxxxxxxxxxxxx: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > When the crtc is enabled but !active, we should still compute the > > watermarks as if the planes were visible. That would make it more > > likely that the we can later transition to active without errors. > > > > Add a FIXME to remind people that we're doing the wrong thing now. > > We should perhaps just move the wm computation for each individual plane > > into the .check_plane hook, and later we'd just combine the results from > > all active planes. > For both patches: > > Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> > > Not sure how much use there is to calculate watermarks for disabled planes, and then ignore them, > but definitely something to keep in mind. I guess you didn't read what I wrote? ;) Series pushed to dinq. Thanks for the reviews. -- Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
