On Mon, May 09, 2016 at 04:25:40PM +0100, Damien Lespiau wrote: > On Mon, May 09, 2016 at 04:23:44PM +0300, Marius Vlad wrote: > > Easier to catch compilation errors. > > > Having -Werror by default is a no go as you cannot control/predict the > set of warnings (and the quality of those) of all previous and future > gcc/clang versions. > > Always using this flag will cause distributions to hate us. I assumed that much. > > Adding a test (with patchwork integration!) that ensures each commit > posted on this mailing-list compiles without new warning with a chosen > toolchain (and even passes distcheck!) would be nice. We have this for check and distcheck internally. The whole point of Werror was to catch warnings as well when building, and letting us know so we can fix it. The problem is (unfortunately) that not all patches arrive thru m-l. Don't really know how much traction some CI/buildbot for i-g-t will have. > > -- > Damien > > > Signed-off-by: Marius Vlad <marius.c.vlad@xxxxxxxxx> > > --- > > benchmarks/Makefile.am | 2 +- > > demos/Makefile.am | 3 ++- > > overlay/Makefile.am | 3 ++- > > tests/Makefile.am | 2 +- > > tools/Makefile.am | 4 +++- > > 5 files changed, 9 insertions(+), 5 deletions(-) > > > > diff --git a/benchmarks/Makefile.am b/benchmarks/Makefile.am > > index 2c2d100..46992f8 100644 > > --- a/benchmarks/Makefile.am > > +++ b/benchmarks/Makefile.am > > @@ -2,7 +2,7 @@ > > include Makefile.sources > > > > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib > > -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) > > +AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -Werror > > LDADD = $(top_builddir)/lib/libintel_tools.la > > > > benchmarks_LTLIBRARIES = gem_exec_tracer.la > > diff --git a/demos/Makefile.am b/demos/Makefile.am > > index e6fbb3b..9eacd16 100644 > > --- a/demos/Makefile.am > > +++ b/demos/Makefile.am > > @@ -3,5 +3,6 @@ bin_PROGRAMS = \ > > $(NULL) > > > > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib > > -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) > > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \ > > + $(LIBUNWIND_CFLAGS) -Werror > > LDADD = $(top_builddir)/lib/libintel_tools.la > > diff --git a/overlay/Makefile.am b/overlay/Makefile.am > > index c648875..ec68489 100644 > > --- a/overlay/Makefile.am > > +++ b/overlay/Makefile.am > > @@ -3,7 +3,8 @@ bin_PROGRAMS = intel-gpu-overlay > > endif > > > > AM_CPPFLAGS = -I. > > -AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(OVERLAY_CFLAGS) > > +AM_CFLAGS = $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) \ > > + $(OVERLAY_CFLAGS) -Werror > > LDADD = $(DRM_LIBS) $(PCIACCESS_LIBS) $(CAIRO_LIBS) $(OVERLAY_LIBS) > > > > intel_gpu_overlay_SOURCES = \ > > diff --git a/tests/Makefile.am b/tests/Makefile.am > > index 45e3359..22256ce 100644 > > --- a/tests/Makefile.am > > +++ b/tests/Makefile.am > > @@ -59,7 +59,7 @@ AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)\ > > -include "$(srcdir)/../lib/check-ndebug.h" \ > > -DIGT_SRCDIR=\""$(abs_srcdir)"\" \ > > -DIGT_DATADIR=\""$(pkgdatadir)"\" \ > > - $(LIBUNWIND_CFLAGS) \ > > + $(LIBUNWIND_CFLAGS) -Werror \ > > $(NULL) > > > > LDADD = ../lib/libintel_tools.la $(GLIB_LIBS) > > diff --git a/tools/Makefile.am b/tools/Makefile.am > > index df48d94..0ba1ff7 100644 > > --- a/tools/Makefile.am > > +++ b/tools/Makefile.am > > @@ -3,7 +3,9 @@ include Makefile.sources > > SUBDIRS = null_state_gen registers > > > > AM_CPPFLAGS = -I$(top_srcdir) -I$(top_srcdir)/lib > > -AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) -DPKGDATADIR=\"$(pkgdatadir)\" > > +AM_CFLAGS = $(DEBUG_CFLAGS) $(DRM_CFLAGS) $(PCIACCESS_CFLAGS) \ > > + $(CWARNFLAGS) $(CAIRO_CFLAGS) $(LIBUNWIND_CFLAGS) \ > > + -DPKGDATADIR=\"$(pkgdatadir)\" -Werror > > LDADD = $(top_builddir)/lib/libintel_tools.la > > AM_LDFLAGS = -Wl,--as-needed > > > > -- > > 2.8.0.rc3 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
