On Thu, May 05, 2016 at 01:53:57PM +0200, Daniel Vetter wrote: > On Thu, May 05, 2016 at 10:47:10AM +0100, Chris Wilson wrote: > > If we fail to setup the debugfs we lose debugging convenience, but we > > should still endeavour to enable modesetting so that we can control the > > outputs and enable use of the system to debug the issue. In all > > likelihood if we can not create our debugfs files then there is a larger > > underlying issue that will prevent the module loading, but this should > > get us further towards resilience. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Usually the bug is that someone forgot to clean up debugfs files on module > unload, and there's gunk left behind, and that's causing the failure to > load. Since you can't ever recover from leaking debugfs files in this > fashion you need to reboot anyway to make sure your patches are fixed > properly. So I don't see the value of this all that much ... The point is to get a console, even GUI, up and running to be able to reboot. Everything that is not fatal to loading the driver should not prevent the driver from loading. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
