On 20/04/16 13:38, Daniel Vetter wrote:
On Wed, Apr 20, 2016 at 09:00:09AM +0200, Maarten Lankhorst wrote:
Op 19-04-16 om 12:13 schreef Lionel Landwerlin:
On 19/04/16 07:02, Maarten Lankhorst wrote:
Op 18-04-16 om 18:47 schreef Bob Paauwe:
The i915 driver is now using atomic properties and atomic commit
to handle the legacy set gamma IOCTL. However, if the driver is
configured without atomic (nuclear_pageflip = false), it won't
update the legacy properties for degamma_lut, gamma_lut and ctm
leaving them out of sync with the atomic version of the properties.
Until the driver is full atomic, make sure we update the non-atomic
version of the properties.
v2: Update the comment with a FIXME. (Daniel)
Seems to me that this is fixed by [PATCH] drm: atomic: fix legacy gamma set helper?
Not sure why this patch is required on top.
Daniel would prefer to have this fix only in the i915 driver as this is the last driver still transitioning to atomic.
Oh indeed, lack of DRIVER_ATOMIC cap again. :(
Still feels like something that doesn't belong in the driver, but ok..
Agreed, hence why I asked for a FIXME comment so we don't forget to rip
this out once we enale DRIVER_ATOMIC for real.
-Daniel
Hi Daniel,
Was there anything missing in the last version of this patch?
Thanks,
-
Lionel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
