Re: [PATCH 09/10] drm/i915: Enable semaphores for legacy submission on gen8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 28, 2016 at 05:24:31PM +0100, Chris Wilson wrote:
> We have sufficient evidence from igt to support that semaphores are in
> a working state. Enabling semaphores now for legacy provides a better
> comparison of execlists against legacy ring submission.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Somehow my reply didn't make it. Since still disabled by default, and mesa
CI folks confirmed that they stopped disabling execlist on bdw this seems
all safe. And useful for delta-benchmarking execlist.

Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index d37c0a671eed..9fd221c97275 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -542,10 +542,6 @@ bool i915_semaphore_is_enabled(struct drm_device *dev)
>  	if (i915.enable_execlists)
>  		return false;
>  
> -	/* Until we get further testing... */
> -	if (IS_GEN8(dev))
> -		return false;
> -
>  #ifdef CONFIG_INTEL_IOMMU
>  	/* Enable semaphores on SNB when IO remapping is off */
>  	if (INTEL_INFO(dev)->gen == 6 && intel_iommu_gfx_mapped)
> -- 
> 2.8.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux