On 26/04/16 15:18, Daniel Vetter wrote:
On Mon, Apr 25, 2016 at 03:37:11PM +0100, Dave Gordon wrote:Split the function of "enable_guc_submission" into two separate options. The new one ("enable_guc_loading") controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded. In addition, the degree of control has been refined from a simple bool to an integer key, allowing several options: -1 (default) whatever the platform default is 0 DISABLE don't load/use the GuC 1 BEST EFFORT try to load/use the GuC, fallback if not available 2 REQUIRE must load/use the GuC, else leave the GPU wedged The new platform default (as coded here) will be to attempt to load the GuC iff the device has a GuC that requires firmware, but not yet to use it for submission. A later patch will change to enable it if appropriate. Signed-off-by: Dave Gordon <david.s.gordon@xxxxxxxxx>intel-gfx-trybot@fd.o is your CI_only patchwork and CI instance: https://patchwork.freedesktop.org/project/intel-gfx-trybot/series/?ordering=-last_updated Cheers, Daniel
Yes, I tried sending this to trybot several times before this, but it wasn't working well, with many tests giving spurious "INCOMPLETE" results, especially on the Romanian machines. So this was still the only was to get a good test run.
Hopefully trybot will be back in working order soon, but that link shows there has not been a single successful submission by anybody since 1st April!
.Dave. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
