Re: [PATCH v2 2/3] drm/i915: Correct the i915_frequency_info debugfs output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 22, 2016 at 05:22:25PM +0530, akash.goel@xxxxxxxxx wrote:
> From: Akash Goel <akash.goel@xxxxxxxxx>
> 
> There are certain registers, which captures the time elapsed in the
> in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the
> current Up/Down EI and also in the previous Up/Down EI.
> These register values are reported by the i915_frequency_info debugfs
> interface. The Driver prints the 'us' suffix after the values, albeit
> they are actually in raw form & not in microsecond units.
> This patch removes the 'us' suffix so that its clear to User that values
> are indeed in raw form.
> 
> v2: Present the values in microseconds unit also, after platform
>     specific conversion (Chris)
> 
> Signed-off-by: Akash Goel <akash.goel@xxxxxxxxx>
> @@ -1291,21 +1291,21 @@ static int i915_frequency_info(struct seq_file *m, void *unused)
>  		seq_printf(m, "RPDECLIMIT: 0x%08x\n", rpdeclimit);
>  		seq_printf(m, "RPNSWREQ: %dMHz\n", reqf);
>  		seq_printf(m, "CAGF: %dMHz\n", cagf);
> -		seq_printf(m, "RP CUR UP EI: %dus\n", rpupei &
> -			   GEN6_CURICONT_MASK);
> -		seq_printf(m, "RP CUR UP: %dus\n", rpcurup &
> -			   GEN6_CURBSYTAVG_MASK);
> -		seq_printf(m, "RP PREV UP: %dus\n", rpprevup &
> -			   GEN6_CURBSYTAVG_MASK);
> +		seq_printf(m, "RP CUR UP EI: %d(%dus)\n",
> +			   rpupei, GT_PM_INTERVAL_TO_US(dev_priv, rpupei));

A space between raw and time would have been nice.

With that extra character,
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux