On Thu, Apr 14, 2016 at 11:27:25AM +0300, Jani Nikula wrote: > On Wed, 13 Apr 2016, Ben Widawsky <ben@xxxxxxxxxxxx> wrote: > > +module_param_named_unsafe(disable_firmware_loading, i915.disable_firmware_loading, uint, 0400); > > +MODULE_PARM_DESC(disable_firmware_loading, > > + "Bypass loading of firmware based on mask. This overrides all other firmware module parameters. (0:all firmwares enabled (default), 1<<0:disable GuC, 1<<1:disable DMC"); > > I'd like all parameters like this to read "enable", defaulting to > enabled or disabled, possibly with platform specific defaults. > > I know there's the underlying assumption that firmware loading is > enabled by default, therefore disabling is a special case, so you call > this disable. But we've already got enable_whatnot, with all kinds of > defaults. The disable_whatnot ones are confusing. > > I can easily imagine adding platform specific defaults to > enable_firmware_loading, particularly during platform enabling. > > BR, > Jani. I'm happy to change it, but it'd be nice to have some kind of ack that someone will merge it before I bother with that. > > > -- > Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
