On Tue, Apr 12, 2016 at 02:46:16PM +0100, Dave Gordon wrote: > The newly-introduced function i915_gem_object_pin_map() returns an > ERR_PTR (not NULL) if the pin-and-map opertaion fails, so that's what we > must check for. And it's nicer not to assign such a pointer-or-error to > a structure being filled in until after it's been validated, so we > should keep it local and avoid exporting a bogus pointer. Also, for > clarity and symmetry, we should clear 'virtual_start' along with 'vma' > when unmapping a ringbuffer. > > Signed-off-by: Dave Gordon <david.s.gordon@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
