Re: [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2016-04-11 at 16:30 +0300, Ville Syrjälä wrote:
> On Thu, Mar 17, 2016 at 12:23:10PM +0200, Mika Kahola wrote:
> > It was noticed on bug #94087 that module parameter
> > i915.edp_vswing=2 that should override the VBT setting
> > to use default voltage swing (400 mV) was not applied
> > for Broadwell.
> > 
> > This patch provides a fix for this by checking if default
> > i.e. higher voltage swing is requested to be used and
> > applies the DDI translations table for DP instead of eDP
> > (low vswing) table.
> > 
> > v2: Combine two if statements into one (Jani)
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94087
> > Signed-off-by: Mika Kahola <mika.kahola@xxxxxxxxx>
> 
> We didn't get a CI run for this?
No, we didn't. Should I resend this patch for a CI run?

> 
> > ---
> >  drivers/gpu/drm/i915/intel_ddi.c | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index ab025a5..100a532 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -443,9 +443,17 @@ void intel_prepare_ddi_buffer(struct intel_encoder *encoder)
> >  	} else if (IS_BROADWELL(dev_priv)) {
> >  		ddi_translations_fdi = bdw_ddi_translations_fdi;
> >  		ddi_translations_dp = bdw_ddi_translations_dp;
> > -		ddi_translations_edp = bdw_ddi_translations_edp;
> > +
> > +		if (dev_priv->edp_low_vswing) {
> > +			ddi_translations_edp = bdw_ddi_translations_edp;
> > +			n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> > +		} else {
> > +			ddi_translations_edp = bdw_ddi_translations_dp;
> > +			n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> > +		}
> > +
> >  		ddi_translations_hdmi = bdw_ddi_translations_hdmi;
> > -		n_edp_entries = ARRAY_SIZE(bdw_ddi_translations_edp);
> > +
> >  		n_dp_entries = ARRAY_SIZE(bdw_ddi_translations_dp);
> >  		n_hdmi_entries = ARRAY_SIZE(bdw_ddi_translations_hdmi);
> >  		hdmi_default_entry = 7;
> > -- 
> > 1.9.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 


_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux