Re: [PATCH 3/4] drm/i915: Reload PD tables after semaphore wait on gen8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 11, 2016 at 09:16:21AM +0100, Chris Wilson wrote:
> On Mon, Apr 11, 2016 at 10:34:14AM +0300, Ville Syrjälä wrote:
> > On Sat, Apr 09, 2016 at 11:14:45AM +0100, Chris Wilson wrote:
> > > When the engine idles waiting upon a semaphore, it loses its
> > > pagetables and we must reload them before executing the batch.
> > 
> > RCS shouldn't lose them IIRC, other engines yes. As I recall the
> > other way to avoid this would be to prevent the engine from
> > entering some power save mode during the wait, but I suppose
> > that might come at a power cost.
> 
> Right, this only affects !RCS.
> Just changing to if (ppgtt && waiter_req->engine->id != RCS)
> would be enough. Care to give a r-b with that in place since you've
> checked bspec? :)

Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux